[dart][dart-dio] Update dependencies#9122
Conversation
| build_runner: any | ||
| test: '>=1.3.0 <1.16.0' | ||
| dependency_overrides: | ||
| # Needed to make built_value work correctly with Dart 2.12 |
There was a problem hiding this comment.
not sure we want to do that... if we start generating stuff like this it probably mean some deps are not up to date so we should wait until those deps are fixed. You can do that on your own project, but not push that for everyone. Let's see what opinion have other reviewers. I would probably push more to have a null safety generation once dio is ready
There was a problem hiding this comment.
The problem is we have Dart SDK 2.12 in CI and there are not gonna be any new dependency versions for this generator, ever. There is no migration path for the dart-dio generator to 2.12/NNBD. It simply needs to be replaced by the dart-dio-next generator and this one should be deprecated.
We could leave it as is but then we need Dart 2.10 in the CI.
There was a problem hiding this comment.
Your current `analyzer` version may not fully support your current SDK version.
Please try upgrading to the latest `analyzer` by running `flutter packages upgrade`.
Analyzer language version: 2.10.0
SDK language version: 2.12.0
If you are getting this message and have the latest analyzer please file
an issue at https://github.com/dart-lang/sdk/issues/new with the title
"No published analyzer available for language version 2.12.0".
Please search the issue tracker first and thumbs up and/or subscribe to
existing issues if present to avoid duplicates.
There was a problem hiding this comment.
I reverted the changes with the analyzer. I can't get it to build locally with Dart 2.12.0 or 2.12.2 but in CI it only seems to be a warning.
This only fails locally, not sure why. CI only shows a warning.
|
@wing328 I think this can be merged when you have time. |
4 participants
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.xCC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)