[Go] Parse int arrays and respect the 'required' property#9120
Merged
wing328 merged 7 commits intoOpenAPITools:masterfrom Apr 11, 2021
aliakseiz:feature/parse-int-array
Merged
[Go] Parse int arrays and respect the 'required' property#9120wing328 merged 7 commits intoOpenAPITools:masterfrom aliakseiz:feature/parse-int-array
wing328 merged 7 commits intoOpenAPITools:masterfrom
aliakseiz:feature/parse-int-array
Conversation
Contributor
Author
|
Can somebody please restart the CircleCI job? |
…-array # Conflicts: # modules/openapi-generator/src/main/resources/go-server/controller-api.mustache # modules/openapi-generator/src/main/resources/go-server/routers.mustache # samples/server/petstore/go-api-server/go/api_pet.go # samples/server/petstore/go-api-server/go/api_store.go # samples/server/petstore/go-api-server/go/api_user.go # samples/server/petstore/go-api-server/go/routers.go
Member
|
All tests passed. If no further feedback, I'll merge it in the next few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
*Affects the Go-server only.
Integer arrays support in a form
Adds a code generation to parse form parameter fields of
int32 arrayandint64 arraytypes.Before:
After:
Required integer fields
Also parameter's
requiredproperty is not ignored anymore, meaning that missing optional parameters ofint32,int64,[]int32and[]int64types are initialized with0andempty slicerespectively, instead of failing the whole operation.Before/after below assume, that mentioned optional and required fields are missing in the payload.
Before:
After:
Multipart/form-data parsing
Replaces form parsing with more specific call for
multipart/form-data.ParseFormitself doesn't initialize theFilesparameters.Before:
After:
Other
Fixes minor typos and FIXMEs, which caught my eye during debugging.
Technical committee
@antihax @grokify @kemokemo @jirikuncar
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x