Skip to content

Don't deploy to sonar in forks#8856

Merged
jimschubert merged 1 commit intoOpenAPITools:masterfrom
wbt-solutions:publish-sonar-if-not-fork
Feb 27, 2021
Merged

Don't deploy to sonar in forks#8856
jimschubert merged 1 commit intoOpenAPITools:masterfrom
wbt-solutions:publish-sonar-if-not-fork

Conversation

@sbu-WBT
Copy link
Copy Markdown
Contributor

@sbu-WBT sbu-WBT commented Feb 27, 2021

The CI fails every time in a fork because it can't get uploaded to sonar (obviously). This PR fixes this
Taken from https://github.community/t/how-to-detect-a-pull-request-from-a-fork/18363/3

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@sbu-WBT sbu-WBT requested a review from jimschubert as a code owner February 27, 2021 19:05
@jimschubert jimschubert merged commit 6f413f6 into OpenAPITools:master Feb 27, 2021
@sbu-WBT sbu-WBT deleted the publish-sonar-if-not-fork branch February 27, 2021 19:46
@sbu-WBT
Copy link
Copy Markdown
Contributor Author

sbu-WBT commented Feb 27, 2021

@jimschubert
Copy link
Copy Markdown
Member

I thought it might. Will probably just need to move Sonar to a different build definition which uses puul_request_target rather than pull_request

@jimschubert
Copy link
Copy Markdown
Member

@sbu-WBT please try with 5a0b832

@sbu-WBT
Copy link
Copy Markdown
Contributor Author

sbu-WBT commented Feb 28, 2021

Works perfectly, thank you

@wing328 wing328 added this to the 5.1.0 milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants