Skip to content

Better test for go-server#8852

Merged
wing328 merged 1 commit intomasterfrom
go-server-test
Feb 27, 2021
Merged

Better test for go-server#8852
wing328 merged 1 commit intomasterfrom
go-server-test

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Feb 27, 2021

Run go test in the CI to catch issues instead

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 5.1.0 milestone Feb 27, 2021
@wing328 wing328 marked this pull request as ready for review February 27, 2021 10:02
Copy link
Copy Markdown
Contributor

@jirikuncar jirikuncar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@wing328 wing328 merged commit 2c0991d into master Feb 27, 2021
@wing328 wing328 deleted the go-server-test branch February 27, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants