Skip to content

Make nullable fix on all vars in Go#8820

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
therve:therve/go-fix-nullable-vars
Feb 27, 2021
Merged

Make nullable fix on all vars in Go#8820
wing328 merged 2 commits intoOpenAPITools:masterfrom
therve:therve/go-fix-nullable-vars

Conversation

@therve
Copy link
Copy Markdown
Contributor

@therve therve commented Feb 24, 2021

This applies the Nullable change to all variables on the model, instead of just
the ones in vars.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@therve
Copy link
Copy Markdown
Contributor Author

therve commented Feb 24, 2021

@antihax @grokify @kemokemo @jirikuncar 🙇

Copy link
Copy Markdown
Contributor

@jirikuncar jirikuncar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to add an example/test where this applies.

This applies the Nullable change to all variables on the model, instead
of just the ones in vars.
@therve therve force-pushed the therve/go-fix-nullable-vars branch from 51a5c8b to 2b3775e Compare February 24, 2021 15:35
@wing328 wing328 added this to the 5.1.0 milestone Feb 27, 2021
@wing328 wing328 merged commit 3cf9322 into OpenAPITools:master Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants