Skip to content

Fix base type naming in Go#8819

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
therve:therve/go-base-type
Feb 24, 2021
Merged

Fix base type naming in Go#8819
wing328 merged 1 commit intoOpenAPITools:masterfrom
therve:therve/go-base-type

Conversation

@therve
Copy link
Copy Markdown
Contributor

@therve therve commented Feb 24, 2021

Go generation didn't properly named base type in getSchemaType, which ends up
breaking some doc generation.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Go generation didn't properly named base type in `getSchemaType`, which
ends up breaking some doc generation.
@therve
Copy link
Copy Markdown
Contributor Author

therve commented Feb 24, 2021

@antihax @grokify @kemokemo 🙇

@wing328 wing328 added this to the 5.1.0 milestone Feb 24, 2021
@wing328 wing328 merged commit f9b1f98 into OpenAPITools:master Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants