Skip to content

Qt client handle deprecated#8766

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
MartinDelille:qt-deprecated
Feb 24, 2021
Merged

Qt client handle deprecated#8766
wing328 merged 3 commits intoOpenAPITools:masterfrom
MartinDelille:qt-deprecated

Conversation

@MartinDelille
Copy link
Copy Markdown
Contributor

@MartinDelille MartinDelille commented Feb 19, 2021

Add a Q_DECL_DEPRECATED declaration in front of operation or model properties according to the OpenAPI specification

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ravinikam @stkrwork @etherealjoy @muttleyxd

@etherealjoy
Copy link
Copy Markdown
Contributor

etherealjoy commented Feb 19, 2021

interesting.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 22, 2021 •
edited
Loading

@MartinDelille thanks for the PR. When you've time, can you please merge the latest master into your branch and regenerate the samples?

@MartinDelille
Copy link
Copy Markdown
Contributor Author

MartinDelille commented Feb 22, 2021

@wing328 Done

@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 23, 2021 •
edited
Loading

For some reasons, you're still using 5.0.1-SNAPSHOT:

diff --git a/samples/client/petstore/cpp-qt5/.openapi-generator/VERSION b/samples/client/petstore/cpp-qt5/.openapi-generator/VERSION
index 3fa3b389a57..c30f0ec2be7 100644
--- a/samples/client/petstore/cpp-qt5/.openapi-generator/VERSION
+++ b/samples/client/petstore/cpp-qt5/.openapi-generator/VERSION
@@ -1 +1 @@
-5.0.1-SNAPSHOT
\ No newline at end of file
+5.1.0-SNAPSHOT
\ No newline at end of file
Perform git status
On branch pull/8766
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   samples/client/petstore/cpp-qt5/.openapi-generator/VERSION

I'll try to push a commit to this branch to fix it.

@MartinDelille
Copy link
Copy Markdown
Contributor Author

MartinDelille commented Feb 23, 2021

Ok my bad: I didn't rebuild the package with mvn clean package.

@wing328 wing328 merged commit b5c6654 into OpenAPITools:master Feb 24, 2021
@wing328 wing328 added this to the 5.1.0 milestone Mar 16, 2021
@wing328
Copy link
Copy Markdown
Member

wing328 commented Mar 22, 2021

@MartinDelille thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423

@MartinDelille MartinDelille deleted the qt-deprecated branch September 3, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etherealjoy etherealjoy etherealjoy approved these changes

Assignees

No one assigned

Labels

Client: C++ Client: QT Enhancement: General

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@MartinDelille @etherealjoy @wing328