Skip to content

Add monitoring to detect tabs in the templates#8738

Merged
wing328 merged 12 commits intomasterfrom
detect_tab
Feb 23, 2021
Merged

Add monitoring to detect tabs in the templates#8738
wing328 merged 12 commits intomasterfrom
detect_tab

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Feb 18, 2021

Add monitoring to detect tabs in the templates (e.g. dart, kotlin, etc) for a list of folders specified in the script.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@agilob
Copy link
Copy Markdown
Contributor

agilob commented Feb 19, 2021

I think this should be configurable per template/directory at least. golang uses tabs.

@wing328
Copy link
Copy Markdown
Member Author

wing328 commented Feb 19, 2021

@agilob thanks for the review. That's right. Those template folders that need to be monitored should be added to 863f6e7#diff-d7a99fb89f8cfb88b0340a57e1b3024abfdedcb92ea972f0e1810bb6e2ac28dbR7

@wing328 wing328 marked this pull request as ready for review February 23, 2021 09:02
@wing328 wing328 merged commit 9c4c624 into master Feb 23, 2021
@wing328 wing328 deleted the detect_tab branch March 3, 2021 08:11
@wing328 wing328 added this to the 5.1.0 milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants