Skip to content

[cpp-qt5-client ] Improve CMake#8724

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
MartinDelille:better-cmake
Feb 27, 2021
Merged

[cpp-qt5-client ] Improve CMake#8724
wing328 merged 3 commits intoOpenAPITools:masterfrom
MartinDelille:better-cmake

Conversation

@MartinDelille
Copy link
Copy Markdown
Contributor

@MartinDelille MartinDelille commented Feb 16, 2021

Here are some little improvement of the CMake files:

  • Don't use globs to make sure any modification in a file will rebuild it
  • Link ssl and crypto only for Linux

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ravinikam @stkrwork @etherealjoy @muttleyxd

@MartinDelille MartinDelille changed the title Improve CMake [cpp-qt5-client ] Improve CMake Feb 16, 2021
Comment thread samples/client/petstore/cpp-qt5/client/CMakeLists.txt Outdated
@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 21, 2021

Pushed a commit to update the samples. Let's see how that goes.

@wing328 wing328 added this to the 5.1.0 milestone Feb 21, 2021
@wing328 wing328 merged commit 2b71668 into OpenAPITools:master Feb 27, 2021
@MartinDelille MartinDelille deleted the better-cmake branch September 3, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants