Skip to content

[Java][Vert.x] Make ApiHandler reusable#8720

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
slinkydeveloper:issues/8710
Feb 23, 2021
Merged

[Java][Vert.x] Make ApiHandler reusable#8720
wing328 merged 3 commits intoOpenAPITools:masterfrom
slinkydeveloper:issues/8710

Conversation

@slinkydeveloper
Copy link
Copy Markdown
Contributor

@slinkydeveloper slinkydeveloper commented Feb 16, 2021

Fix #8710

This PR deprecates the default no-args constructor for ApiHandler and replaces it with a constructor requiring to provide the implementation, in order to make easier to use the generated code without modifying it

Signed-off-by: Francesco Guardiani [email protected]

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Signed-off-by: Francesco Guardiani <[email protected]>
@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

@slinkydeveloper
Copy link
Copy Markdown
Contributor Author

@thobi73 can you check out this fix? Does it address your concerns?

@thobi73
Copy link
Copy Markdown

thobi73 commented Feb 16, 2021

@thobi73 can you check out this fix? Does it address your concerns?

Perfect, exactly what I need! Thank you!

Signed-off-by: Francesco Guardiani <[email protected]>
Signed-off-by: Francesco Guardiani <[email protected]>
@wing328 wing328 added this to the 5.1.0 milestone Feb 21, 2021
@wing328 wing328 merged commit 4bf0983 into OpenAPITools:master Feb 23, 2021
@wing328
Copy link
Copy Markdown
Member

wing328 commented Mar 22, 2021

@slinkydeveloper thanks for the PR, which has been included in the v5.1.0 release: https://twitter.com/oas_generator/status/1373636654024380423

@slinkydeveloper slinkydeveloper deleted the issues/8710 branch March 22, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] [VERTX_WEB] Use DefaultApiHandler with an own implementation of ApiImpl

4 participants