[Java][Client] Add Quarkus support by djnalluri · Pull Request #8716 · OpenAPITools/openapi-generator

djnalluri · 2021-02-16T02:19:01Z

This PR adds support for Quarkus in the Microprofile library for the Java client. These changes, for the most part, should not affect any existing usage with the exception of disableMultipart being renamed to enableMultipart and new annotations being used when withXml is enabled. To generate for Quarkus, set the library to microprofile and add the additional property named microprofileFramework set to quarkus.

Summary of changes:

Added JSON-B as supported serialization library
Added CLI option for controlling output of Swagger annotations
Merged Microprofile-specific model templates into the general Java client templates
Removed unused Microprofile templates
Fixes [REQ] Java MicroPofile Rest client with Jackson serialization? #8015
Support for using 'asyncNative' property to toggle usage of CompletionStage or Mutiny (void return not supported)

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master, 5.1.x, 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Technical Committee:
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

agilob · 2021-02-16T21:50:31Z

        } else if (SERIALIZATION_LIBRARY_GSON.equals(getSerializationLibrary())) {
            additionalProperties.put(SERIALIZATION_LIBRARY_GSON, "true");
            additionalProperties.remove(SERIALIZATION_LIBRARY_JACKSON);
+            additionalProperties.remove(SERIALIZATION_LIBRARY_JSONB);


this is the place where you should use switch/case for these instead adding another else if

agilob · 2021-02-16T21:50:39Z

                model.imports.add("IOException");
            }
+            if (additionalProperties.containsKey(SERIALIZATION_LIBRARY_JSONB)) {
+                //TODO: Fill this out


I left it intentionally blank as a marker for future optimization. But indeed, it should be removed or stated to be so.

agilob · 2021-02-16T21:51:15Z

-            model.imports.remove("ApiModel");
-            model.imports.remove("JsonSerialize");
-            model.imports.remove("ToStringSerializer");
+//        if (MICROPROFILE.equals(getLibrary())) {


revert commented out or fix and remove

agilob · 2021-02-16T21:51:36Z

            this.serializationLibrary = SERIALIZATION_LIBRARY_JACKSON;
        } else if (SERIALIZATION_LIBRARY_GSON.equalsIgnoreCase(serializationLibrary)) {
            this.serializationLibrary = SERIALIZATION_LIBRARY_GSON;
+        } else if (SERIALIZATION_LIBRARY_JSONB.equalsIgnoreCase(serializationLibrary)) {


another place for switch/case

agilob · 2021-02-16T21:55:09Z

    }
+
+    @Override
+    public Map<String, String> typeMapping() {


I dont think this override is needed here. typeMapping() is defined as public method in DefaultCodeGen and this doesnt change any behaviour. it returns the same typeMapping hashmap.

agilob · 2021-02-16T21:57:04Z

  }

- /**
+   /**


extra whitespace adds chaos to review

agilob · 2021-02-16T21:57:28Z

   * Get firstName
   * @return firstName
  **/
+  @javax.annotation.Nullable


this should land in its own PR

agilob · 2021-02-16T21:59:53Z

   * (except the first line).
   */
-  private static String toIndentedString(Object o) {
+  private String toIndentedString(Object o) {


this is potentially a breaking change with no fallback config

agilob · 2021-02-16T22:00:45Z

-    return this;
+
+  @Override
+  public boolean equals(Object o) {


This also belongs in its own PR, only adds chaos to this review that's long already

agilob · 2021-02-16T22:04:06Z

As it's a good effort I think this PR has way too many changes to go all in, it should be at last 4-7. There are at least 2 breaking changes in here as well, rename of config flag, change of static method (which looks to be static intentionally).

djnalluri · 2021-02-16T22:48:21Z

I'm closing this PR and will break it up into multiple PR's as suggested. Thanks for the feedback.

melloware · 2022-08-15T16:38:19Z

@djnalluri was this ever implemented? I am looking for Quarkus support of Microprofile.

djnalluri · 2022-08-15T16:53:14Z

This hasn't been implemented yet. The series of PR's I was hoping to break things into are layered on each other. Progress on this is stuck on #8801. You could check out the Quarkiverse plugin. It uses OpenAPI generator under the hood. https://github.com/quarkiverse/quarkus-openapi-generator

melloware · 2022-08-15T16:55:51Z

OK you rock this Quarkiverse plugin looks like exactly what I am looking for.

djnalluri added 4 commits February 15, 2021 01:50

First draft at Quarkus support.

d9808c1

Remove usage of String.toUpperCase()

295d370

Minimize changes in samples and fix generation issue.

c57f47e

Update samples.

e95cf61

agilob reviewed Feb 16, 2021

View reviewed changes

djnalluri closed this Feb 16, 2021

This was referenced Feb 17, 2021

[Java][Client] JSON-B serialization support #8729

Merged

[Java][Client] Add CLI option to select OpenAPI annotation library #8801

Closed

                 }
-               /**
+                 /**

Uh oh!

Conversation

djnalluri commented Feb 16, 2021

PR checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

agilob commented Feb 16, 2021

Uh oh!

djnalluri commented Feb 16, 2021

Uh oh!

melloware commented Aug 15, 2022

Uh oh!

djnalluri commented Aug 15, 2022

Uh oh!

melloware commented Aug 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants