Skip to content

Insert mime/multipart import#8683

Closed
worming004 wants to merge 1 commit intoOpenAPITools:masterfrom
worming004:master
Closed

Insert mime/multipart import#8683
worming004 wants to merge 1 commit intoOpenAPITools:masterfrom
worming004:master

Conversation

@worming004
Copy link
Copy Markdown

@worming004 worming004 commented Feb 11, 2021

The package mime/multipart is used at line 100, but wasn't imported.
Also, the added blank linespace in dependencies is added by gofmt by default.

It's a miss from #8103, even commented by @ys

mention @jirikuncar

Imo, there is no hurry to push it as hotfix as there is any easy workaround : add this line manually. Error generated by go compiler is clear enough

PR checklist

  • [ X] Read the contribution guidelines.
  • [X ] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • [ X] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

The package mime/multipart is used at line 100, but wasn't imported.
Also, the added blank linespace in dependencies is added by gofmt by default.
@worming004
Copy link
Copy Markdown
Author

Sorry for not completing locally the build part. I am not a java developer and I do not want to spend times on installation and configuration.

@worming004
Copy link
Copy Markdown
Author

I see there is an error during ci build. Could I have some guidance or doc to correct it ?

@worming004
Copy link
Copy Markdown
Author

@kemokemo @grokify @antihax

@jirikuncar
Copy link
Copy Markdown
Contributor

jirikuncar commented Feb 15, 2021

@worming004 check Run the following to build the project and update samples bullet from PR template. It should fix the build error. In your case ./bin/generate-samples.sh bin/configs/go-*server* should be enough.

@worming004
Copy link
Copy Markdown
Author

I am unfortunately unable to complete your request. After installing java, I encounter several issues

  • When running ./bin/generate-samples.sh bin/configs/go-*server*, the command returned Error: Unable to access jarfile <path to repository>/modules/openapi-generator-cli/target/openapi-generator-cli.jar
  • When running ./mvnw clean package the processus is stuck after [main] WARN org.openapitools.codegen.utils.ModelUtils - Multiple schemas found in the OAS 'content' section, returning only the first one (application/xml)

@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 27, 2021

closed via #8790

@wing328 wing328 closed this Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants