Fix syntax errors and method calls in code generated by Crystal client generator#8644
Merged
wing328 merged 4 commits intoOpenAPITools:masterfrom Feb 8, 2021
Merged
Conversation
Member
I've pushed a commit with updated samples. Let's see how that goes. |
Member
I did a test on a Windows laptop and the project is compiling fine for me. Please open a new issue to track this. |
wing328
approved these changes
Feb 8, 2021
Member
wing328
left a comment
There was a problem hiding this comment.
LGTM. CircleCI failure not related to this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you so much for adding a Crystal client generator! I got a little ambitious and attempted to generate a Stripe API client from their OAS3 definition. From inside that repo, I ran the following:
Then I spun up a new Crystal app:
crystal init app test_stripeshard.ymlwithpath: ../stripesrc/test_stripe.cr:crystal src/test_stripe.crThere were a few compiler errors for a Crystal project I spun up to test-drive it and I've gotten all the ones I found nailed down here. For the most part, it just looked like some method calls missed in copying over the Ruby generator. And then there were a couple syntax errors — a stray
]character and unescaped quotes in a string. Nothing major so far.Unfortunately, I had trouble running the
./mvnw clean packagecommand to check my changes or make sure I've caught everything. I'm getting never-ending exceptions in running it — it looks like the instrumentation to capture the exception is also raising exceptions. So I may need a little guidance there./cc @wing328
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x