Fix handling of 1xx and 3xx in Rust Reqwest#8551
Closed
gferon wants to merge 7 commits intoOpenAPITools:masterfrom
Closed
Fix handling of 1xx and 3xx in Rust Reqwest#8551gferon wants to merge 7 commits intoOpenAPITools:masterfrom
gferon wants to merge 7 commits intoOpenAPITools:masterfrom
Conversation
Since 1xx and 3xx are perfectly valid status codes the client might need to handle. see: https://docs.rs/reqwest/0.11.0/reqwest/struct.StatusCode.html#method.is_informational
gferon
force-pushed
the
rust-small-fixes
branch
from
713581a to
5932193
Compare
gferon
force-pushed
the
rust-small-fixes
branch
from
5932193 to
4e96428
Compare
Member
|
@gferon thanks for the PR, which looks like a bug fix to me so I've retargeted this PR to the current master instead. cc @frol (2017/07) @farcaller (2017/08) @richardwhiuk (2019/07) @paladinzh (2020/05) |
Contributor
Author
|
Thanks! I'll rebase the branch on master then so the diff looks better. |
5 tasks
Member
|
Closing this one as I've cherry-pick your commits and filed #8574 instead. If no further feedback from anyone, I'll merge that PR over the weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
Err(...)was returned for 1xx and 3xx status codes, which are totally valid response code and should be returned withOk(...)instead.Also removed a redundant
use(found usingclippy).I filed this on the
5.1.xbranch since I think it qualifies as a hotfix, but feel free to change it to something more appropriate.Tagging @farcaller for the Rust review.