Skip to content

[Qt5][C++] Fixed QByteArray::toUtf8 with FILE as request body. Included <stdexcept>.#8550

Merged
wing328 merged 4 commits intoOpenAPITools:masterfrom
igor-sirotin:bugfix/cpp-qt5
Jan 30, 2021
Merged

[Qt5][C++] Fixed QByteArray::toUtf8 with FILE as request body. Included <stdexcept>.#8550
wing328 merged 4 commits intoOpenAPITools:masterfrom
igor-sirotin:bugfix/cpp-qt5

Conversation

@igor-sirotin
Copy link
Copy Markdown
Contributor

@igor-sirotin igor-sirotin commented Jan 27, 2021 •
edited
Loading

  • Added '#include ' where std::runtime_error is used
    I get a build error with MSVC 16.6.30114.105 without this include:
error C2039: 'runtime_error': is not a member of 'std'
error C3861: 'runtime_error': identifier not found

  • Fixed QByteArray::toUtf8 with FILE as request body
    In api-body.mustache there's .toUtf8() call on QString output to get a valid QByteArray for the following input.request_body.append(const QByteArray&). This one is not needed when output is obtained already as QByteArray.

  • Updated related samples

  • Updated generator docs

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

ping @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)

@igor-sirotin
Multiple cpp-qt5-client bugfixes.
8d34872 
* Added '#include <stdexcept>' where std::runtime_error is used
* Fixed request with FILE body: QByteArray doesn't have ::toUtf8()
* Updated related samples
@igor-sirotin
Fixed isByteArray section
b1137ef
@igor-sirotin
updated docs
dc3db5b
MartinDelille
MartinDelille suggested changes Jan 27, 2021
View reviewed changes
Comment thread docs/generators/fsharp-functions.md Outdated
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jan 29, 2021

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 wing328 added this to the 5.0.1 milestone Jan 29, 2021
@igor-sirotin
Copy link
Copy Markdown
Contributor Author

igor-sirotin commented Jan 29, 2021 •
edited
Loading

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

@wing328, oops, my fault!
Added this e-mail to my GitHub account. Thanks for the tip.

@etherealjoy
Copy link
Copy Markdown
Contributor

etherealjoy commented Jan 29, 2021

@igor-sirotin
Changes looks good to me. Were you able to compile this also on Linux?

@igor-sirotin
Copy link
Copy Markdown
Contributor Author

igor-sirotin commented Jan 29, 2021 •
edited
Loading

@etherealjoy, no, I haven't done that.
Totally relied on CI, because the changes aren't OS-dependent.

@wing328 wing328 merged commit 328cadb into OpenAPITools:master Jan 30, 2021
@igor-sirotin igor-sirotin deleted the bugfix/cpp-qt5 branch January 30, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etherealjoy etherealjoy etherealjoy approved these changes

+2 more reviewers

@MartinDelille MartinDelille MartinDelille requested changes

@muttleyxd muttleyxd muttleyxd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Client: C++ Issue: Bug

Projects

None yet

Milestone

5.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@igor-sirotin @wing328 @etherealjoy @MartinDelille @muttleyxd