Skip to content

[Swift] move swift config files under ./bin/config#8539

Merged
wing328 merged 2 commits intomasterfrom
swift-ensure-update
Jan 26, 2021
Merged

[Swift] move swift config files under ./bin/config#8539
wing328 merged 2 commits intomasterfrom
swift-ensure-update

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Jan 26, 2021

  • move swift config files under ./bin/config to ensure the samples are up-to-date
  • move bitrise config to the top level so that it can be used directly by bitrise.io

cc @jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@4brunu
Copy link
Copy Markdown
Contributor

4brunu commented Jan 26, 2021

Looks good to me 👍

@wing328 wing328 merged commit cbd2038 into master Jan 26, 2021
@wing328 wing328 deleted the swift-ensure-update branch February 4, 2021 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants