[feature][python-flask] Add CORS support to python-flask server#8472
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Jan 29, 2021
Merged
[feature][python-flask] Add CORS support to python-flask server#8472wing328 merged 3 commits intoOpenAPITools:masterfrom
wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
Contributor
|
@ceresek thank you for your PR. The feature generally looks good but it broke tests in circle and travis. Can you get them passing? |
Contributor
Author
|
@spacether Thank you for your comments. I fixed the Travis issue (forgot to update the samples and that was the check that failed), but I might need some advice with Circle. The parallel logs are a bit challenging to read, but the only serious failure I see is Maven failing to fetch a dependency from the Maven Central, with lots of "Connection reset" errors, and the same test builds and runs fine locally. What am I missing ? |
Contributor
|
Thank you for your sample fix. It looks like circle balked when it tried to download a maven package. I just restarted it which may resolve it. Let's wait and see. |
Member
|
All tests passed 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic CORS support to the server generated with the
python-flaskgenerator (and the derivedpython-aiohttpandpython-blueplanet). Enabled withfeatureCORSoption (same as similar option in other generators). Disabled by default.Mentioning TC members for Python as instructed in the PR checklist: @taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether.