[JMeter] Support json data in csv#8461
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Jan 25, 2021
kannkyo:jmeter-support-json-body
Merged
[JMeter] Support json data in csv#8461wing328 merged 1 commit intoOpenAPITools:masterfrom kannkyo:jmeter-support-json-body
wing328 merged 1 commit intoOpenAPITools:masterfrom
kannkyo:jmeter-support-json-body
Conversation
wing328
reviewed
Jan 25, 2021
| <elementProp name="{{paramName}}" elementType="HTTPArgument"> | ||
| <boolProp name="HTTPArgument.always_encode">false</boolProp> | ||
| {{=<% %>=}}<stringProp name="Argument.value">${<% paramName %>}</stringProp><%={{ }}=%> | ||
| {{=<% %>=}}<stringProp name="Argument.value">${__javaScript("${<% paramName %>}".replace(/'/g\, '"'),)}</stringProp><%={{ }}=%> |
Member
There was a problem hiding this comment.
@kannkyo thanks for the fix. I think one limitation with such approach is that if the json data contains ', e.g.
{
"name": "John O'Shea"
}the result will not work as it will become:
{
"name": "John O"Shea"
}I'm happy to merge this fix while looking for better approach to address cases like the above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8460
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master