Spring codegen - fix equals and hashCode methods for byte array and binary#8345
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Jan 28, 2021
ccoltx:master
Merged
Spring codegen - fix equals and hashCode methods for byte array and binary#8345wing328 merged 3 commits intoOpenAPITools:masterfrom ccoltx:master
wing328 merged 3 commits intoOpenAPITools:masterfrom
ccoltx:master
Conversation
…inary - they should be compared using Arrays.equals - they're hash code generated using Arrays.hashCode
Contributor
Author
|
This pull request is ready to be reviewed, can someone please take a look? |
Contributor
Author
|
Can one of the maintainers please have a look at this! |
Contributor
Author
|
Any update? |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1448
Binary and Byte Arrays
Spring codegen has been updated and the Tests updated.
PR checklist
Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.File the PR against the correct branch:
master,5.1.x,6.0.xCopy the technical committee to review the pull request if your PR is targeting a particular programming language.
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)