Skip to content

[typescript-axios] reduce file size#8283

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
sapphi-red:typescript-axios-reduce-file-size
Jan 26, 2021
Merged

[typescript-axios] reduce file size#8283
wing328 merged 2 commits intoOpenAPITools:masterfrom
sapphi-red:typescript-axios-reduce-file-size

Conversation

@sapphi-red
Copy link
Copy Markdown
Contributor

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

This PR does not implement any new features nor fix any bugs.
It reduces the file size of the output.

For example, the file size diff with my project is below.

Before After Diff Diff (%)
without terser 1119717 bytes 886594 bytes -233123 bytes -20.82%
with terser 269873 bytes 183810 bytes -86063 bytes -31.89%
with terser+gz 17734 bytes 15545 bytes -2189 bytes -12.34%

After generating, I ran npx typescript --module amd --target es2015 --outFile i.js index.ts and used terser REPL and GZip Size Online with level 9.

@auto-labeler
Copy link
Copy Markdown

auto-labeler Bot commented Dec 28, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 5.0.1 milestone Jan 26, 2021
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jan 26, 2021

@sapphi-red thanks for the refactoring, which looks good to me.

@wing328 wing328 added the Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. label Jan 26, 2021
@wing328 wing328 merged commit fb1b628 into OpenAPITools:master Jan 26, 2021
@sapphi-red sapphi-red deleted the typescript-axios-reduce-file-size branch April 15, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client: TypeScript Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. Enhancement: Performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants