Skip to content

[Swift 5] remove old swift sample#8280

Merged
wing328 merged 4 commits intoOpenAPITools:masterfrom
4brunu:feature/remove-old-swift-sample
Jan 25, 2021
Merged

[Swift 5] remove old swift sample#8280
wing328 merged 4 commits intoOpenAPITools:masterfrom
4brunu:feature/remove-old-swift-sample

Conversation

@4brunu
Copy link
Copy Markdown
Contributor

@4brunu 4brunu commented Dec 28, 2020

This old sample is not used anymore.
So this PR removes it.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

@4brunu
Copy link
Copy Markdown
Contributor Author

4brunu commented Dec 28, 2020

The build is failing because in the bitrise CI, we are using the configuration file in the bitrise console, instead of the bitrise.yml file in the repository.

I updated the bitrise.yml, but it's not having effect because of what I described.

I found this guide on how to use the bitrise.yml in the repository.
https://devcenter.bitrise.io/tips-and-tricks/use-bitrise-yml-from-repository/

The main advantage, is that for example in this PR, I need to change the build settings, and I can do it directly in this PR.

@wing328 what do you think? Could we start to use the bitrise.yml file in the repository?

Thanks

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jan 4, 2021

@wing328 what do you think? Could we start to use the bitrise.yml file in the repository?

Agreed. I couldn't find a way before. Let's coordinate later today or this week to make this change so that we can use bitrise.yml from the repository instead.

@wing328 wing328 added this to the 5.0.1 milestone Jan 4, 2021
@4brunu
Copy link
Copy Markdown
Contributor Author

4brunu commented Jan 11, 2021

Hey @wing328,
Any news on this? 🙂
Can I help?
Thanks

@wing328 wing328 merged commit 3a56e38 into OpenAPITools:master Jan 25, 2021
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jan 25, 2021

Just merged it and update bitrise.yml config in the CI provider.

@4brunu
Copy link
Copy Markdown
Contributor Author

4brunu commented Jan 25, 2021

Thanks

@wing328
Copy link
Copy Markdown
Member

wing328 commented Jan 25, 2021

@4brunu but looks like it breaks the build. Please take a look when you've time. I've PM'd you the details via Slack.

@4brunu 4brunu deleted the feature/remove-old-swift-sample branch February 8, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Client: Swift Enhancement: CI/Test

Projects

None yet

Milestone

5.0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@4brunu @wing328