Skip to content

[dart-dio] Remove code fo additionalPropertiesType#8196

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
kuhnroyal:dart-dio/unused-code
Dec 16, 2020
Merged

[dart-dio] Remove code fo additionalPropertiesType#8196
wing328 merged 1 commit intoOpenAPITools:masterfrom
kuhnroyal:dart-dio/unused-code

Conversation

@kuhnroyal
Copy link
Copy Markdown
Contributor

The additionalPropertiesType is correctly typed as BuiltMap<String, Type> in all examples, with or without this change and the import is correct.
The jsonFormat is unused for dart-dio.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

CC @swipesight (2018/09) @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12)

Copy link
Copy Markdown
Contributor

@agilob agilob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this should be part of one of the previous PRs. good to go.

@wing328 wing328 added this to the 5.0.0 milestone Dec 16, 2020
@wing328 wing328 merged commit 80df0b0 into OpenAPITools:master Dec 16, 2020
@kuhnroyal kuhnroyal deleted the dart-dio/unused-code branch December 16, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants