Skip to content

fix: use config basePath instead of the class context basePath#8186

Merged
macjohnny merged 3 commits intoOpenAPITools:masterfrom
sahanatroam:fix/typescript-axios-basePath
Dec 15, 2020
Merged

fix: use config basePath instead of the class context basePath#8186
macjohnny merged 3 commits intoOpenAPITools:masterfrom
sahanatroam:fix/typescript-axios-basePath

Conversation

@sahanatroam
Copy link
Copy Markdown
Contributor

@sahanatroam sahanatroam commented Dec 14, 2020 •
edited by macjohnny
Loading

fixes #8176

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@sahanatroam sahanatroam mentioned this pull request Dec 14, 2020
Closed
6 tasks
@wing328
Copy link
Copy Markdown
Member

wing328 commented Dec 15, 2020

For the CircleCI failure, can you please merge the latest master into your branch as we've fixed that issue in the master already?

@sahanatroam
Copy link
Copy Markdown
Contributor Author

sahanatroam commented Dec 15, 2020

@wing328 that didn't quite work, unsure what the issue might be here. Are you able to help?

@wing328
Copy link
Copy Markdown
Member

wing328 commented Dec 15, 2020 

Dec 15, 2020 3:59:06 AM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: I/O exception (java.net.SocketException) caught when processing request to {s}->https://repo.maven.apache.org:443: Connection reset
Dec 15, 2020 3:59:06 AM org.apache.maven.wagon.providers.http.httpclient.impl.execchain.RetryExec execute
INFO: Retrying request to {s}->https://repo.maven.apache.org:443
[ERROR] Failed to execute goal net.alchim31.maven:scala-maven-plugin:3.1.5:add-source (scala-compile-first) on project openapi-scala-client: Execution scala-compile-first of goal net.alchim31.maven:scala-maven-plugin:3.1.5:add-source failed: Plugin net.alchim31.maven:scala-maven-plugin:3.1.5 or one of its dependencies could not be resolved: The following artifacts could not be resolved: org.scala-lang:scala-library:jar:2.9.2, com.typesafe.sbt:incremental-compiler:jar:0.12.1, org.scala-lang:scala-compiler:jar:2.9.2: Could not transfer artifact org.scala-lang:scala-library:jar:2.9.2 from/to central (https://repo.maven.apache.org/maven2): GET request of: org/scala-lang/scala-library/2.9.2/scala-library-2.9.2.jar from central failed: Connection reset -> [Help 1]
[ERROR]

Due to throttling as this project is too active, I'll restart the job an hour later to see if we've any luck.

macjohnny
macjohnny approved these changes Dec 15, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny added this to the 5.0.0 milestone Dec 15, 2020
@macjohnny macjohnny marked this pull request as ready for review December 15, 2020 08:40
@macjohnny macjohnny merged commit 6f5076e into OpenAPITools:master Dec 15, 2020
@sahanatroam sahanatroam deleted the fix/typescript-axios-basePath branch December 15, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@macjohnny macjohnny macjohnny approved these changes

Assignees

No one assigned

Labels

Client: TypeScript

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[BUG][typescript-axios] 'this' implicitly has type 'any' because it does not have a type annotation.

3 participants

@sahanatroam @wing328 @macjohnny