[GO][Client] return GenericOpenAPIError instead of error in Execute() by code-lucidal58 · Pull Request #8137 · OpenAPITools/openapi-generator

code-lucidal58 · 2020-12-09T06:51:38Z

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master
Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)

code-lucidal58 · 2020-12-09T09:25:16Z

Code snippet used to test the generated client code

result, _, err := r.Execute()
if err.Error() != "" {
	return fmt.Errorf("error occurred while updating object: %s Response: %s", err.Error(), string(err.Body()))
}

Output:

Error: error occurred while updating VnicEthIf object: 400 Bad Request Response: <response body as it is >

Earlier Output:

Error: error occurred while updating VnicEthIf object: 400 Bad Request Response:

When printing the error err only because error does not support .Body(), GenerateOpenAPIError does.

wing328 · 2020-12-09T09:26:46Z


 {{#operations}}
 import (
+  "bytes"


@code-lucidal58 what about using tabs instead of 4-spaces for this line and some other lines below?

I use tabs. And looks fine in Atom and Intellij. Not sure why it looks different here. Let me try again

wing328 · 2020-12-09T15:01:42Z

Looks like there are syntax errors causing build failure:

# _/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/go/go-petstore
go-petstore/api_another_fake.go:95:2: syntax error: non-declaration statement outside function body
FAIL	_/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/go [build failed]
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (go-test) on project GoPetstore: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]

…enapi-generator into go-api-return-response

code-lucidal58 · 2020-12-10T16:35:02Z

All errors fixed @wing328

code-lucidal58 · 2020-12-11T07:44:33Z

Not able to figure out why the circleci build fails.

wing328 · 2020-12-13T16:22:33Z

I think you will need to update the test as well. Here is the error reported by the CI:

Download https://repo1.maven.org/maven2/org/junit/platform/junit-platform-engine/1.4.0/junit-platform-engine-1.4.0.jar
Download https://repo1.maven.org/maven2/org/junit/jupiter/junit-jupiter-api/5.4.0/junit-jupiter-api-5.4.0.jar
Download https://repo1.maven.org/maven2/org/junit/platform/junit-platform-commons/1.4.0/junit-platform-commons-1.4.0.jar
:processResources UP-TO-DATE
:classes
:compileTestJava UP-TO-DATE
:compileTestGroovy
:processTestResources UP-TO-DATE
:testClasses
:test

BUILD SUCCESSFUL

Total time: 22.356 secs
# _/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/go/mock
mock/mock_api_pet.go:20:29: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:28:32: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:36:39: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:44:37: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:52:33: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:60:32: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:68:40: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:76:33: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
mock/mock_api_pet.go:84:49: cannot use m (type *MockPetApi) as type petstore.PetApi in field value:
	*MockPetApi does not implement petstore.PetApi (wrong type for AddPetExecute method)
		have AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, error)
		want AddPetExecute(petstore.ApiAddPetRequest) (*http.Response, petstore.GenericOpenAPIError)
FAIL	_/home/circleci/OpenAPITools/openapi-generator/samples/client/petstore/go [build failed]
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (go-test) on project GoPetstore: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :GoPetstore
2020-12-13 15:52:05.344:INFO::main: Logging initialized @106ms

…rator into go-api-return-response

wing328 · 2020-12-14T07:48:12Z

All tests passed. If no further feedback/question from anyone, I'll merge it on coming Wed.

…xecute() (#8137)" This reverts commit 1562afe.

…xecute() (#8137)" (#8427) This reverts commit 1562afe.

code-lucidal58 added 2 commits December 9, 2020 12:18

error to GenericOpenAPIError

6776142

reformatted files

2c6310e

wing328 reviewed Dec 9, 2020

View reviewed changes

code-lucidal58 added 3 commits December 9, 2020 15:09

reformat files

c90e33f

spaces to tabs

e14b2e7

update petstore examples

0896d69

wing328 added Client: Go Issue: Bug labels Dec 9, 2020

code-lucidal58 added 4 commits December 9, 2020 22:41

remove extra brackets

b82207b

Merge branch 'master' into go-api-return-response

9c468fd

Merge branch 'go-api-return-response' of github.com:code-lucidal58/op…

c176097

…enapi-generator into go-api-return-response

update sample generation

0176e83

wing328 added this to the 5.0.0 milestone Dec 13, 2020

code-lucidal58 added 4 commits December 14, 2020 07:44

Merge branch 'master' of https://github.com/OpenAPITools/openapi-gene…

cb2e136

…rator into go-api-return-response

update go test cases

578c514

update openapi3 go tests

88fb2eb

edit test samples

fd7a8a1

wing328 added the Breaking change (without fallback) label Dec 14, 2020

update documentation

180e4a3

wing328 merged commit 1562afe into OpenAPITools:master Dec 17, 2020

thiagoarrais mentioned this pull request Dec 23, 2020

[BUG][GO][Client] Returned err is never nil #8263

Closed

5 tasks

thiagoarrais mentioned this pull request Jan 5, 2021

[GO][Client] Return error in Execute() methods #8344

Closed

6 tasks

wing328 added a commit that referenced this pull request Jan 13, 2021

Revert "[GO][Client] return GenericOpenAPIError instead of error in E…

9088d29

…xecute() (#8137)" This reverts commit 1562afe.

wing328 mentioned this pull request Jan 13, 2021

Revert "[GO][Client] return GenericOpenAPIError instead of error in Execute() (#8137)" #8427

Merged

6 tasks

wing328 added a commit that referenced this pull request Jan 14, 2021

Revert "[GO][Client] return GenericOpenAPIError instead of error in E…

22ac8fa

…xecute() (#8137)" (#8427) This reverts commit 1562afe.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[GO][Client] return GenericOpenAPIError instead of error in Execute()#8137

[GO][Client] return GenericOpenAPIError instead of error in Execute()#8137
wing328 merged 14 commits intoOpenAPITools:masterfrom
code-lucidal58:go-api-return-response

code-lucidal58 commented Dec 9, 2020 •

edited

Loading

Uh oh!

code-lucidal58 commented Dec 9, 2020

Uh oh!

wing328 Dec 9, 2020 •

edited

Loading

Uh oh!

code-lucidal58 Dec 9, 2020

Uh oh!

code-lucidal58 Dec 9, 2020

Uh oh!

wing328 commented Dec 9, 2020

Uh oh!

code-lucidal58 commented Dec 10, 2020

Uh oh!

code-lucidal58 commented Dec 11, 2020

Uh oh!

wing328 commented Dec 13, 2020

Uh oh!

wing328 commented Dec 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

code-lucidal58 commented Dec 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

code-lucidal58 commented Dec 9, 2020

Uh oh!

wing328 Dec 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

code-lucidal58 Dec 9, 2020

Choose a reason for hiding this comment

Uh oh!

code-lucidal58 Dec 9, 2020

Choose a reason for hiding this comment

Uh oh!

wing328 commented Dec 9, 2020

Uh oh!

code-lucidal58 commented Dec 10, 2020

Uh oh!

code-lucidal58 commented Dec 11, 2020

Uh oh!

wing328 commented Dec 13, 2020

Uh oh!

wing328 commented Dec 14, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

code-lucidal58 commented Dec 9, 2020 •

edited

Loading

wing328 Dec 9, 2020 •

edited

Loading