Skip to content

[C][Client] Update the function of releasing memory when a map is deleted#8122

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
ityuhui:yh-fix-map-memleak
Dec 9, 2020
Merged

[C][Client] Update the function of releasing memory when a map is deleted#8122
wing328 merged 1 commit intoOpenAPITools:masterfrom
ityuhui:yh-fix-map-memleak

Conversation

@ityuhui
Copy link
Copy Markdown
Contributor

@ityuhui ityuhui commented Dec 8, 2020

Discussed in PR #8107, this PR replaces free() with the function keyValuePair_free() to free the map itself.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 @zhemant @michelealbano

@auto-labeler
Copy link
Copy Markdown

auto-labeler Bot commented Dec 8, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 5.0.0 milestone Dec 9, 2020
@wing328 wing328 merged commit 828e924 into OpenAPITools:master Dec 9, 2020
@wing328
Copy link
Copy Markdown
Member

wing328 commented Dec 9, 2020

@ityuhui thanks for the PR. I'll try to find some time this weekend to run the report again and see if there's anything to be fixed before the 5.0.0 release this month.

@ityuhui ityuhui deleted the yh-fix-map-memleak branch December 10, 2020 02:23
@ityuhui
Copy link
Copy Markdown
Contributor Author

ityuhui commented Dec 10, 2020

OK. Looking forward to the scan result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants