Skip to content

[CircleCI] add default cache#8120

Merged
wing328 merged 1 commit intomasterfrom
circleci_default_cache
Dec 8, 2020
Merged

[CircleCI] add default cache#8120
wing328 merged 1 commit intomasterfrom
circleci_default_cache

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Dec 8, 2020

  • add default cache for PR as currently PR cannot recover any cache to start with

cc @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328
Copy link
Copy Markdown
Member Author

wing328 commented Dec 8, 2020

Need to merge now to address the CircleCI build failure with PRs we've been seeing lately.

@wing328 wing328 merged commit 0b6d70d into master Dec 8, 2020
@wing328 wing328 added this to the 5.0.0 milestone Dec 8, 2020
@wing328 wing328 deleted the circleci_default_cache branch December 21, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant