[JAXRS-spec] Added support for cookie parameters#8117
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Dec 8, 2020
alfabetacain:fix_issue2908
Merged
[JAXRS-spec] Added support for cookie parameters#8117wing328 merged 1 commit intoOpenAPITools:masterfrom alfabetacain:fix_issue2908
wing328 merged 1 commit intoOpenAPITools:masterfrom
alfabetacain:fix_issue2908
Conversation
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Contributor
Author
|
Wrong email used. Thanks a lot :-) |
5 tasks
wing328
pushed a commit
that referenced
this pull request
Oct 3, 2023
{{>cookieParams}} was introduced to generated classes but not for the only interface use case in #8117
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for cookie parameters to the jaxrs-spec generator, which should fix #2908.
Added the test case
testGenerateApiWithCookieParameter_issue2908toJavaJAXRSSpecServerCodegenTest.java, which uses the fileissue_2908.yamlfor testing that cookie parameter generation works.Briefly, the fix was adding a new mustache template (
cookieParams.mustache) to the jaxrs-spec generator and referencing it inapi.mustachein the same way the other parameter types are referenced (e.g.queryParams.mustache).The new
cookieParams.mustacheis essentially a copy of thequeryParams.mustache.PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.mastercc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)