Skip to content

[dart][dart-dio] Enum fixes specific to Dart DIO#8114

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
kuhnroyal:dart/dio-enum-fixes
Dec 9, 2020
Merged

[dart][dart-dio] Enum fixes specific to Dart DIO#8114
wing328 merged 2 commits intoOpenAPITools:masterfrom
kuhnroyal:dart/dio-enum-fixes

Conversation

@kuhnroyal
Copy link
Copy Markdown
Contributor

@kuhnroyal kuhnroyal commented Dec 7, 2020

  • fix wrong escaped built_value serializer names
  • prevent enum name collisions in inlined enums by prefixing the private built_value instances with the enum class name. This prevents clashes when multiple inline enums contain the same value - for example EnumTest. No breaking changes here as all the changed fields/references are private and automatically re-generated with built_value.

There is still a lot wrong with enums but this is a small step.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@kuhnroyal
Copy link
Copy Markdown
Contributor Author

FYI @agilob @josh-burton

@kuhnroyal
Copy link
Copy Markdown
Contributor Author

CC @ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @athornz (2019/12) @amondnet (2019/12)

@agilob
Copy link
Copy Markdown
Contributor

agilob commented Dec 7, 2020

tech committee of dart is dead, it's @sbu-WBT @agilob and @noordawod now

and you

@kuhnroyal
Copy link
Copy Markdown
Contributor Author

This should fix #8097

Prefix the private built_value instances with the enum class name. Prevents clashes when multiple inline enums contain the same value - for example `EnumTest`.  No breaking changes here as all the changed fields/references are private and automatically re-generated with built_value.
@kuhnroyal kuhnroyal force-pushed the dart/dio-enum-fixes branch from af76a42 to e9891b3 Compare December 9, 2020 11:19
@wing328 wing328 added this to the 5.0.0 milestone Dec 9, 2020
@wing328 wing328 merged commit 2cdbfd6 into OpenAPITools:master Dec 9, 2020
@kuhnroyal kuhnroyal deleted the dart/dio-enum-fixes branch December 9, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants