Skip to content

Better handling of operationId in the Elm client generator#8109

Merged
wing328 merged 1 commit intomasterfrom
elm-operation-id
Dec 7, 2020
Merged

Better handling of operationId in the Elm client generator#8109
wing328 merged 1 commit intomasterfrom
elm-operation-id

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Dec 7, 2020

To close #8070

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @eriktim

@wing328 wing328 changed the title etter operationId in elm client generator Better operationId in the Elm client generator Dec 7, 2020
@wing328 wing328 added this to the 5.0.0 milestone Dec 7, 2020
@wing328 wing328 changed the title Better operationId in the Elm client generator Better handling of operationId in the Elm client generator Dec 7, 2020
Copy link
Copy Markdown
Contributor

@eriktim eriktim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wing328 wing328 merged commit ed72843 into master Dec 7, 2020
@wing328 wing328 deleted the elm-operation-id branch December 7, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ELM] Functions generated from operationId can have invalid names

2 participants