Skip to content

[C][Client] Fix memory leak when deleting a map#8107

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
ityuhui:yh-fix-free-res
Dec 7, 2020
Merged

[C][Client] Fix memory leak when deleting a map#8107
wing328 merged 1 commit intoOpenAPITools:masterfrom
ityuhui:yh-fix-free-res

Conversation

@ityuhui
Copy link
Copy Markdown
Contributor

@ityuhui ityuhui commented Dec 6, 2020

When deleting a map in the *_free() function of a model, the original codes only free the memory for key and value of the map, but forget to free the memory of map (keyValuePair_t) itself.

list_free({{classname}}->{{name}}) only frees the memory of each listEntry_t *listEntry, does not free the map itself too.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 @zhemant @michelealbano

@auto-labeler
Copy link
Copy Markdown

auto-labeler Bot commented Dec 6, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 added this to the 5.0.0 milestone Dec 7, 2020
@wing328
Copy link
Copy Markdown
Member

wing328 commented Dec 7, 2020

CircleCI failure not related to this change.

@wing328 wing328 merged commit 3195338 into OpenAPITools:master Dec 7, 2020
@ityuhui
Copy link
Copy Markdown
Contributor Author

ityuhui commented Dec 7, 2020

Thanks @wing328

But I found a function keyValuePair_free today.

void keyValuePair_free(keyValuePair_t *keyValuePair) {
    free(keyValuePair);
}

Although there is only one line free(keyValuePair) in the function body, but I think it's better to use this function to fix the memory-leak of this PR.

free (localKeyValue) -> keyValuePair_free(localKeyValue)

I will create another PR to deliver this change, sorry for the change.

@ityuhui ityuhui deleted the yh-fix-free-res branch December 7, 2020 02:20
@wing328
Copy link
Copy Markdown
Member

wing328 commented Dec 7, 2020

No worry. Looking forward to your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants