Skip to content

feat(config): pull the basePath from config is exists#8078

Merged
macjohnny merged 4 commits intoOpenAPITools:masterfrom
sahanatroam:feature/use-config-basePath
Dec 7, 2020
Merged

feat(config): pull the basePath from config is exists#8078
macjohnny merged 4 commits intoOpenAPITools:masterfrom
sahanatroam:feature/use-config-basePath

Conversation

@sahanatroam
Copy link
Copy Markdown
Contributor

@sahanatroam sahanatroam commented Dec 2, 2020

fixes #8065
A user must be able to simply define the basePath as they are constructing the Service.

Current:

const healthCheckService = new HealthcheckApi({}, process.env.REACT_APP_API_ENDPOINT)

Once this PR is approved:

const healthCheckService = new HealthcheckApi({ basePath: process.env.REACT_APP_API_ENDPOINT })

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

Comment thread modules/openapi-generator/src/main/resources/typescript-axios/apiInner.mustache Outdated
@sahanatroam sahanatroam requested a review from macjohnny December 6, 2020 19:54
Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny added this to the 5.0.0 milestone Dec 7, 2020
@macjohnny macjohnny merged commit a3aa199 into OpenAPITools:master Dec 7, 2020
@sahanatroam sahanatroam deleted the feature/use-config-basePath branch December 7, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] typescript-axios basePath to be passed as config

2 participants