Fix bug [python][client] generated python client code cannot POST object in multipart/form-data#8075
Merged
spacether merged 7 commits intoOpenAPITools:masterfrom Dec 7, 2020
Merged
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
spacether
reviewed
Dec 3, 2020
spacether
reviewed
Dec 3, 2020
…part/form-data fix issue OpenAPITools#8068
…t-type:application/json; charset=utf-8"
… discussion in PR review.
… PR review comment.
itaru2622
commented
Dec 7, 2020
Contributor
Author
There was a problem hiding this comment.
I should fix my mistake about line 259, as below:
if collection_types is None:
- collection_types = (dict,list)
+ collection_types = (dict)
spacether
approved these changes
Dec 7, 2020
Contributor
spacether
left a comment
spacether
left a comment
There was a problem hiding this comment.
This looks great, thank you for the PR and the update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as described in #8068 , encode object to json and add 'content-type:application/json' for sending multipart/form-data.
and checked if the request is sent to server with collect format described in #8068.
fix #8068
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master@taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether @wing328 @jimschubert