Fixes issue #8014, _check_type flag not being honored.#8053
Merged
spacether merged 2 commits intoOpenAPITools:masterfrom Dec 7, 2020
Merged
Fixes issue #8014, _check_type flag not being honored.#8053spacether merged 2 commits intoOpenAPITools:masterfrom
spacether merged 2 commits intoOpenAPITools:masterfrom
Conversation
Updated model_utils.mustache to pass the check_type flag into attempt_convert_item(). Failure to do so results in type validation errors occurring when the user has specifically requested that they be disabled.
Contributor
Author
|
Regarding the failure in the CircleCI build... I don't understand why this is failing. The test in question appears to be using a java client, and this PR does not touch the java client. |
fbl100
force-pushed
the
fix_issue_8014
branch
from
7ac644e to
ebb16e4
Compare
spacether
changed the title
spacether
approved these changes
Dec 7, 2020
Contributor
spacether
left a comment
spacether
left a comment
There was a problem hiding this comment.
Thank you for the PR! This looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated model_utils.mustache to pass the check_type flag into attempt_convert_item(). Failure to do so
results in type validation errors occurring when the user has specifically requested that they be disabled.
@spacether if this is not the 'right' way to fix this, then I may need some assistance with my model. This fix works for my code.
Fixes:
#8014
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master