Skip to content

Fix list examples in Python (for real)#8034

Merged
spacether merged 1 commit intoOpenAPITools:masterfrom
therve:therve/fix-python-list-examples-part-2
Nov 26, 2020
Merged

Fix list examples in Python (for real)#8034
spacether merged 1 commit intoOpenAPITools:masterfrom
therve:therve/fix-python-list-examples-part-2

Conversation

@therve
Copy link
Copy Markdown
Contributor

@therve therve commented Nov 26, 2020

The patch in #7967 forgot the prefix, this fixes it, and change the samples so
that we can see the effect this time.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

The patch in OpenAPITools#7967 forgot the prefix, this fixes it, and change the
sampels so that we can see the effect this time.
@therve
Copy link
Copy Markdown
Contributor Author

therve commented Nov 26, 2020

@spacether
Copy link
Copy Markdown
Contributor

Thank you for the PR and adding the sample update.

Copy link
Copy Markdown
Contributor

@spacether spacether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@spacether spacether merged commit 3f75691 into OpenAPITools:master Nov 26, 2020
@spacether spacether added this to the 5.0.0 milestone Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants