Skip to content

Add a script to detect changes in test files#8020

Merged
wing328 merged 3 commits intomasterfrom
show_test_warning
Dec 4, 2020
Merged

Add a script to detect changes in test files#8020
wing328 merged 3 commits intomasterfrom
show_test_warning

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Nov 25, 2020

Add a script to detect changes in test files to avoid deleted test files or regenerated test files with no actual test case.

cc @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 marked this pull request as ready for review November 30, 2020 04:43
@wing328 wing328 added this to the 5.0.0 milestone Dec 2, 2020
@wing328 wing328 merged commit 64c57e3 into master Dec 4, 2020
@wing328 wing328 deleted the show_test_warning branch December 4, 2020 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant