[ruby] make the generated ruby oneOf specs pass#8019
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Nov 25, 2020
jfeltesse-mdsol:fix/oneof_spec
Merged
[ruby] make the generated ruby oneOf specs pass#8019wing328 merged 1 commit intoOpenAPITools:masterfrom jfeltesse-mdsol:fix/oneof_spec
wing328 merged 1 commit intoOpenAPITools:masterfrom
jfeltesse-mdsol:fix/oneof_spec
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
zippolyte
approved these changes
Nov 25, 2020
Contributor
zippolyte
left a comment
There was a problem hiding this comment.
Thanks for this fix ! That looks good to me, though you'll probably need to update the samples too
Contributor
Author
I ran the command but nothing came out. If the samples don't use oneOf then nothing would change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec wrongly assumed the items in the oneOf schema were all models.
Solves the issue described in #5706 (comment)
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master@cliffano (2017/07) @zlx (2017/09) @autopp (2019/02) @zippolyte @wing328