[JAXRS-CXF] Generate missing jackson annotations in inner enum#7879
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Nov 26, 2020
Merged
Conversation
added 2 commits
November 4, 2020 22:03
…ional property jackson (preparational commit) generated using: ./bin/generate-samples.sh ./bin/configs/other/jaxrs-cxf-client-jackson.yaml
fix for generators jaxrs-cxf and jaxrs-cxf-client
wing328
approved these changes
Nov 26, 2020
Member
wing328
left a comment
There was a problem hiding this comment.
Tested locally and the result is good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For inner enum classes, the generators
jaxrs-cxfandjaxrs-cxf-clientdo not properly annotate the generated methodstoString(missing@JsonValue) andfromValue(missing@JsonCreator), when the additional propertyjacksonis set.This bug is only present in
enumClass.mustacheresponsible for inner enum classes. It is not present inenumOuterClass.mustache, which is responsible for regular enum classes.This bug is resolved by this PR.
Hint for the reviewer: The first commit of this PR introduces a new petstore sample for
jaxrs-cxf-clientwith additional propertyjacksonset totrue. The second commit provides the actual fix.PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.mastercc: @wing328 @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda