Skip to content

[JAXRS-CXF] Generate missing jackson annotations in inner enum#7879

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
cowclaw:jaxrs_cxf_generate_missing_jackson_annotations
Nov 26, 2020
Merged

[JAXRS-CXF] Generate missing jackson annotations in inner enum#7879
wing328 merged 2 commits intoOpenAPITools:masterfrom
cowclaw:jaxrs_cxf_generate_missing_jackson_annotations

Conversation

@cowclaw
Copy link
Copy Markdown
Contributor

@cowclaw cowclaw commented Nov 4, 2020

For inner enum classes, the generators jaxrs-cxf and jaxrs-cxf-client do not properly annotate the generated methods toString (missing @JsonValue) and fromValue (missing @JsonCreator), when the additional property jackson is set.

This bug is only present in enumClass.mustache responsible for inner enum classes. It is not present in enumOuterClass.mustache, which is responsible for regular enum classes.

This bug is resolved by this PR.

Hint for the reviewer: The first commit of this PR introduces a new petstore sample for jaxrs-cxf-client with additional property jackson set to true. The second commit provides the actual fix.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc: @wing328 @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda

Florian Kamella added 2 commits November 4, 2020 22:03
…ional property jackson (preparational commit)

generated using: ./bin/generate-samples.sh ./bin/configs/other/jaxrs-cxf-client-jackson.yaml
fix for generators jaxrs-cxf and jaxrs-cxf-client
Copy link
Copy Markdown
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and the result is good.

@wing328 wing328 added this to the 5.0.0 milestone Nov 26, 2020
@wing328 wing328 merged commit c950384 into OpenAPITools:master Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants