[Dart2] Fix compile errors for required enums without default value.#7877
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Nov 24, 2020
Merged
Conversation
Contributor
|
You need to run |
Contributor
Author
|
@agilob The petstore sample is not affected by this change actually, that's why this PR only modifies the template files. Do you want me to add specific test cases for this? |
Contributor
|
@wing328 can we get this in pls? |
Member
|
@agilob Sorry for late reply as we were busy with the v5.0.0-beta3 release. @gilbsgilbs can you please resolve the merge conflicts when you've time? |
Also fix display of minimum/maximum comment.
0efa375 to
5a18352
Compare
Contributor
Author
|
@wing328 ✅ Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
Would produce the following Dart code which would fail to compile (because of a missing required parameter):
This PR skips the enum initialization when no default value is provided.
Also, when a minimum value was specified for a property, I think there was a comment expected to display but wasn't (because it was in a wrong section). If fixed the comment value and put it in the proper section so that it shows.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master