Skip to content

Fixed the HttpSigning issue for query string#7859

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
Ghufz:fix_HttpSigning_QueryString
Nov 2, 2020
Merged

Fixed the HttpSigning issue for query string#7859
wing328 merged 1 commit intoOpenAPITools:masterfrom
Ghufz:fix_HttpSigning_QueryString

Conversation

@Ghufz
Copy link
Copy Markdown
Contributor

@Ghufz Ghufz commented Nov 2, 2020

Fixed the query string issue in HttpSigning .

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
    @wing328

@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 2, 2020

CircleCI failure already fixed in the master.

@wing328 wing328 merged commit d179574 into OpenAPITools:master Nov 2, 2020
@wing328 wing328 added this to the 5.0.0 milestone Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants