Skip to content

Fix NPE in CodegenIgnoreProcessor.java (fixes #3356)#7846

Merged
jimschubert merged 1 commit intoOpenAPITools:masterfrom
jbrower2:patch-1
Nov 11, 2020
Merged

Fix NPE in CodegenIgnoreProcessor.java (fixes #3356)#7846
jimschubert merged 1 commit intoOpenAPITools:masterfrom
jbrower2:patch-1

Conversation

@jbrower2
Copy link
Copy Markdown
Contributor

There is a NullPointerException thrown when using an override ignore file with no parent.

This is not specific to a particular language; it impacts all generators.

See #3356

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

There is a NullPointerException thrown when using an override ignore file with no parent.

See #3356
@jbrower2
Copy link
Copy Markdown
Contributor Author

jbrower2 commented Nov 4, 2020

Tagging the Python committee because the original issue was logged against Python.

@taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether

@jimschubert
Copy link
Copy Markdown
Member

@jbrower2 thanks for this. I'll look at adding a test to cover this condition in a separate PR.

@jimschubert jimschubert merged commit ec13288 into OpenAPITools:master Nov 11, 2020
@jbrower2 jbrower2 deleted the patch-1 branch November 11, 2020 16:18
@wing328 wing328 added this to the 5.0.0 milestone Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants