[rust-server] Add support for bearer token authentication#7840
Merged
richardwhiuk merged 3 commits intoOpenAPITools:masterfrom Jan 30, 2021
mattdowdell:rust-server/bearerAuthSupport
Merged
[rust-server] Add support for bearer token authentication#7840richardwhiuk merged 3 commits intoOpenAPITools:masterfrom mattdowdell:rust-server/bearerAuthSupport
richardwhiuk merged 3 commits intoOpenAPITools:masterfrom
mattdowdell:rust-server/bearerAuthSupport
Conversation
As far as I can tell, the bulk of the work to support bearer auth was already implemented to support OAuth, but never explicitly turned on. I've added a new sample which appears to be working correcltly, but I may have unwittingly overlooked something. Changes: - Added bearer auth to the security features for rust server - Supplemented the basic auth condition in the context template to handled basic auth and bearer auth separately. - Repurpose an exising sample to confirm the code generation works as expected. The new sample builds without problems, so the only possibly issue is that the underlying `swagger` crate didn't implement this. However, there's already bearer support in the client and it's also used in the OAuth support in the server, so I don;t see why it wouldn't work.
mattdowdell
changed the title
Contributor
|
Nope looks good to me. I think we've just not had a requirement to support Bearers outside of OAuth before, so it's just not come up. Thanks! |
Contributor
|
(Client support is already present - ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell, the bulk of the work to support bearer tokens was already implemented to support OAuth, but never explicitly turned on. This was unexpectedly simple, so I susect I may have missed something.
Changes:
The new sample builds without problems, so the only possibly issue is that the underlying
swaggercrate didn't implement this. However, there's already bearer support in the client and it's also used in the OAuth support in the server, so I don't see why it wouldn't work.PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.masterCC @frol @farcaller @richardwhiuk @paladinzh