Expose JsonSerializerSettings in ApiClient#7582
Merged
wing328 merged 4 commits intoOpenAPITools:masterfrom Nov 26, 2020
Merged
Conversation
wing328
reviewed
Oct 3, 2020
Member
|
@davidyee thanks for the PR. I wonder if you can add a new A good reference is |
Member
|
FYI. I've filed #7583 to default |
16ad51a to
ed2e5a2
Compare
ed2e5a2 to
7cf23cd
Compare
Contributor
Author
|
@wing328 Thanks for the feedback and suggestions. I've included revisions to my PR in my latest commits. |
Member
|
@davidyee thanks for the PR, which has been merged into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I expose the JsonSerializerSettings in the ApiClient so that serialization customizations can be done. For example, in my specific use-case, I wanted to add additional Converters to change the way JSON was being deserialized back into the csharp classes.
Fixes #4241
I reviewed the comments made on this related PR #4466 and incorporated the feedback into this PR.
@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02)
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master