[php][bug] Fix offsetGet in model generic to return offset rather than bool|null#7571
Merged
jimschubert merged 2 commits intoOpenAPITools:masterfrom Oct 2, 2020
Merged
[php][bug] Fix offsetGet in model generic to return offset rather than bool|null#7571jimschubert merged 2 commits intoOpenAPITools:masterfrom
jimschubert merged 2 commits intoOpenAPITools:masterfrom
Conversation
Reverted previous behavior for offsetGet method
jimschubert
changed the title
jimschubert
approved these changes
Oct 2, 2020
Member
|
Thanks for the bug fix! Usually I'd wait for template maintainer responses before merge. It's been ~7 years since I last used PHP, but I think the fix here is pretty obvious. If one of the template maintainers has any concerns, please open another issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverted previous behavior for offsetGet method
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master@jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ackintosh (2017/09) ❤️, @ybelenko (2018/07), @renepardon (2018/12)