Implement useAbstractionForFiles for webclient library#7567
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Jan 25, 2021
Merged
Implement useAbstractionForFiles for webclient library#7567wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
1f79c5e to
276f95d
Compare
Contributor
Author
|
I'm not sure why the circleci build is still failing |
Member
|
@iyzana can you please resolve the merge conflicts when you've time? We'll look into the CI issue later if it's still failing. |
276f95d to
267877c
Compare
Contributor
Author
|
rebased |
Member
|
Pushed f9a8614 to fix CI failures. Let's see how that goes. |
Contributor
|
@noako when you update the java.md docs as part of #8549 , please consider mentioning that the useAbstractionForFiles is also supported for webclient library. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request extends #6912 by providing an implementation of the new
useAbstractionForFilesflag for the webclient library.The original issue was #6715 . I left a comment on that ticket mentioning that the functionality would be nice to have for the webclient as well.
In this PR I mostly just adapted the changes that were necessary for the resttemplate to work for the webclient.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda