Skip to content

[core] Make loggers static final where possible#7562

Merged
jimschubert merged 1 commit intoOpenAPITools:masterfrom
agilob:make-loggers-static-final
Oct 2, 2020
Merged

[core] Make loggers static final where possible#7562
jimschubert merged 1 commit intoOpenAPITools:masterfrom
agilob:make-loggers-static-final

Conversation

@agilob
Copy link
Copy Markdown
Contributor

@agilob agilob commented Oct 1, 2020

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)

@jimschubert
Copy link
Copy Markdown
Member

Awesome. Thanks.

@jimschubert jimschubert changed the title Make loggers static final where possible [core] Make loggers static final where possible Oct 2, 2020
@jimschubert jimschubert merged commit 4fe76fc into OpenAPITools:master Oct 2, 2020
@wing328 wing328 added this to the 5.0.0 milestone Oct 26, 2020
@agilob agilob deleted the make-loggers-static-final branch September 9, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants