Skip to content

[maven] environmentVariables -> globalProperties#7559

Merged
jimschubert merged 1 commit intoOpenAPITools:masterfrom
jimschubert:maven-global-props
Oct 2, 2020
Merged

[maven] environmentVariables -> globalProperties#7559
jimschubert merged 1 commit intoOpenAPITools:masterfrom
jimschubert:maven-global-props

Conversation

@jimschubert
Copy link
Copy Markdown
Member

The global properties option replaced system properties in 4.x. Maven has always had the incorrectly named environmentVariables. This updates the maven plugin to align with the proper naming by issuing a warning for removal in 5.1.0

cc @OpenAPITools/generator-core-team

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@auto-labeler
Copy link
Copy Markdown

auto-labeler Bot commented Oct 1, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@jimschubert jimschubert merged commit 150e24d into OpenAPITools:master Oct 2, 2020
@jimschubert jimschubert deleted the maven-global-props branch October 2, 2020 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant