[BUG][Python] init access token for python client configuration#7469
Merged
spacether merged 2 commits intoOpenAPITools:masterfrom Feb 5, 2021
Merged
[BUG][Python] init access token for python client configuration#7469spacether merged 2 commits intoOpenAPITools:masterfrom
spacether merged 2 commits intoOpenAPITools:masterfrom
Conversation
|
@zilvinasu @spacether @arunnalla @taxpon @cbornet |
spacether
reviewed
Feb 1, 2021
spacether
approved these changes
Feb 5, 2021
Contributor
There was a problem hiding this comment.
Looks good to me, @zilvinasu can you move this PR out of draft state?
Circle CI appears to keep failing because of:
Unknown SSL protocol error in connection to get.haskellstack.org:443 which is unrelated to these changes
Edit: nvm i can do it
Thank you for your PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating Python client for my OpenAPI and it is outputting invalid Python code, it generates a Configuration class, which is trying to use self.access_token which is not initialised to any default value.
closes #7468
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master@spacether @arun-nalla @taxpon @cbornet