[Java][RestTemplate] useAbstractionForFiles - Use Resource interface instead of AbstractResource#7051
Merged
wing328 merged 4 commits intoOpenAPITools:masterfrom Jul 27, 2020
Conversation
Sync with master
Sync with master
Sync with master
…e when useAbstractionForFiles=true.
Contributor
Author
|
Adding the Java technical committee as requested - @wing328 @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda. Please review. |
wing328
approved these changes
Jul 27, 2020
Member
wing328
left a comment
wing328
left a comment
There was a problem hiding this comment.
Tested locally and the result is good.
MosheElisha
deleted the
resource_interface_for_files_instead_of_abstract_resource
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When useAbstractionForFiles=true, use Resource interface instead AbstractResource class to allow greater degree of freedom for the users calling the API methods.
A little improvement for #6715.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master