Skip to content

Fix string comparison in Python generator's abstract class#7030

Merged
wing328 merged 4 commits intomasterfrom
python-str-compare
Jul 24, 2020
Merged

Fix string comparison in Python generator's abstract class#7030
wing328 merged 4 commits intomasterfrom
python-str-compare

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented Jul 23, 2020

  • Fix string comparison
  • rename PythonAbstractConnexionServerCodegen.java to AbstractPythonConnexionServerCodegen.java

cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 changed the title Fix string comparison in PythonAbstractConnexionServerCodegen.java Fix string comparison in Python generator's abstract class Jul 23, 2020
@wing328 wing328 merged commit 5f8e28a into master Jul 24, 2020
@wing328 wing328 deleted the python-str-compare branch July 24, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant