[Java][jersey2] fix query parameters in applyToParams#7028
Merged
Conversation
timgclark
reviewed
Jul 23, 2020
|
|
||
| client.updateParamsForAuth(authNames, queryParams, headerParams, null, null, "post", uri); | ||
|
|
||
| // hard to test as expire will always be different |
Contributor
There was a problem hiding this comment.
I spent far too long yesterday thinking about exactly this test. I think this may be sufficient:
Signature requestSignature = Signature.fromString(headerParams.get("Authorization"), Algorithm.RSA_SHA512);
Verifier verify = new Verifier(PEM.readPublicKey(new ByteArrayInputStream(publicKeyPem.getBytes())), requestSignature);
assert verify.verify("post", uri.toString(), headerParams);
Member
Author
There was a problem hiding this comment.
@timgclark I've merged this PR into master. I wonder if you can file a separate PR to enhance the test. Thank you.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix query parameters in
applyToParamswith null check and using.equalsfor string comparisonPR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.mastercc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)